Adjust timeout to ignore pull activity#112
Open
adrum wants to merge 2 commits into
Open
Conversation
Collaborator
|
The idle-timeout approach is the right call, and the doc comment is ok. A few things before I'll merge:
|
Address review feedback on the idle-timeout readiness wait: - Add an absolute maxWait backstop (default 300s) on top of the idle timeout. Without it, a container that keeps emitting output every few seconds but never reaches 'running' would refresh the activity clock forever and hang 'up -d' indefinitely. - On a failed wait, cancel the streaming run task and stop the container so the 'container run' subprocess doesn't leak in the background while 'up' moves on to the next service. - Extract ActivityClock into its own file with an injectable clock, and add unit tests covering touch()/lastActivity under concurrent access and the idle-window timing logic.
Author
|
@Cyb3rDudu Great feedback! I have addressed all three. I set the ceiling to 5 minutes, as I felt 3 would be on the edge of too short. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some bigger images on slower networks could exceed the 30s timeout. This modifies
container-compose up -dto consider pull activity progress to determine if the command is dormant or not.