Apply focus halo suppression to all PrimeVue buttons#641
Merged
Conversation
The :focus:not(:focus-visible) rule was previously scoped only to .icon-action-btn, so it only worked on the icon-only resend/trash buttons in the workspace Members and project Collaborators tables. Other invitation-related buttons (the labeled Resend pill on the dashboard, the X on the dashboard, the labeled buttons in the invitation sidebar) kept the lingering focus halo after a mouse click. Move the rule out of .icon-action-btn and apply it globally to .p-button. The :focus-visible exclusion still preserves the focus ring for keyboard navigation, so accessibility is unaffected.
Coverage Report for CI Build 27756579169Coverage remained the same at 92.156%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
MarcelGeo
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #638.
Supress the focus halo ring for all buttons.
Keyboard accessibility stays.