Skip to content

fix: fixed the old social bindings resurfacing when they have already…#1064

Draft
Sahil2004 wants to merge 1 commit into
mainfrom
fix/oldSocialBindings
Draft

fix: fixed the old social bindings resurfacing when they have already…#1064
Sahil2004 wants to merge 1 commit into
mainfrom
fix/oldSocialBindings

Conversation

@Sahil2004

@Sahil2004 Sahil2004 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

… binded.

Description of change

Critical to know

The logic removes from backend the social bindings that came due to mistakenly re-scanning of qr even after binding was already done between the two parties. If we need to have an update by rescanning the qr, then the logic added in this PR needs to change.

Issue Number

Closes #1001

Type of change

  • Fix (a change which fixes an issue)

How the change has been tested

Manually.

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

@Sahil2004 Sahil2004 self-assigned this Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 078ebe9f-f8e9-4153-9b99-40b3ee1dee12

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/oldSocialBindings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Previously added bindings appear as Social Connection Requests when opening QR code scanner

1 participant