Skip to content

fix: footer hardcoded year, dead hrefs, and non-functional newsletter #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nacho1499 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: footer hardcoded year, dead hrefs, and non-functional newsletter #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce9942b
fix: RecentActivity uses the wrong icons for each metric
Nacho1499 Jul 27, 2026
5f609d3
refactor(footer): optimize LogiQuestFooter component
Nacho1499 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
247 changes: 61 additions & 186 deletions src/components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,26 @@ import logiquest from "../assets/logiquest.png";
import { Linkedin, Twitter, Github } from "lucide-react";

export default function LogiQuestFooter() {
// Placeholder for logo - replace with: import logiquest from '../assets/logiquest.png'; height='100'%3E%3Crect fill='%2306b6d4' width='100' height='100'/%3E%3Ctext x='50' y='50' font-size='40' text-anchor='middle' dy='.3em' fill='white'%3ELQ%3C/text%3E%3C/svg%3E";
const gameModes = [
"Classic Mode",
"Challenge Mode",
"Multiplayer Mode",
"Daily Challenge",
"Themed Quests",
"Timed Blitz",
"Puzzle Mode",
"Practice Mode",
"Adventure Mode",
];

const infoLinks = ["FAQs", "Pricing", "Status", "Blog", "Policy"];

const bottomLinks = [
"About us",
"Terms & Conditions",
"Contact us",
"Privacy policy",
];

return (
<footer className="bg-black text-white">
Expand All @@ -27,105 +46,17 @@ export default function LogiQuestFooter() {
Game Mode
</h3>
<ul className="space-y-2 sm:space-y-3">
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Classic Mode
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Challenge Mode
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Multiplayer Mode
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Daily Challenge
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Themed Quests
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Timed Blitz
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Puzzle Mode
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Practice Mode
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Adventure Mode
</a>
</li>
{gameModes.map((mode) => (
<li key={mode} className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">•</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
{mode}
</a>
</li>
))}
</ul>
</div>

Expand All @@ -135,61 +66,17 @@ export default function LogiQuestFooter() {
Info
</h3>
<ul className="space-y-2 sm:space-y-3">
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
FAQs
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Pricing
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Status
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Blog
</a>
</li>
<li className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">
•
</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
Policy
</a>
</li>
{infoLinks.map((item) => (
<li key={item} className="flex items-start">
<span className="text-white mr-2 mt-1 text-xs">•</span>
<a
href="#"
className="text-gray-300 hover:text-cyan-400 transition-colors text-sm"
>
{item}
</a>
</li>
))}
</ul>
</div>

Expand All @@ -199,22 +86,25 @@ export default function LogiQuestFooter() {
Newsletter
</h3>
<p className="text-gray-300 text-sm mb-4 sm:mb-6 leading-relaxed">
Subscribe to our weekly newsletter dose for updated,
Tips, Helps Info and exclusive offers.
Subscribe to our weekly newsletter dose for updated, Tips, Helps
Info and exclusive offers.
</p>

<div className="mb-4 sm:mb-6">
<form onSubmit={(e) => e.preventDefault()} className="mb-4 sm:mb-6">
<div className="flex flex-col sm:flex-row gap-2">
<input
type="email"
placeholder="Your email"
className="flex-1 px-4 py-3 bg-transparent border border-gray-600 rounded-md text-white placeholder-gray-500 focus:outline-none focus:border-cyan-400 transition-colors text-sm"
/>
<button className="px-6 py-3 bg-teal-800 hover:bg-teal-700 text-white rounded-md transition-colors text-sm font-medium whitespace-nowrap">
<button
type="submit"
className="px-6 py-3 bg-teal-800 hover:bg-teal-700 text-white rounded-md transition-colors text-sm font-medium whitespace-nowrap"
>
Subscribe now
</button>
</div>
</div>
</form>

{/* Social Icons */}
<div className="flex space-x-4 mb-4 sm:mb-6">
Expand Down Expand Up @@ -299,37 +189,22 @@ export default function LogiQuestFooter() {
<div className="max-w-7xl mx-auto px-4 sm:px-6 md:px-8 py-4 sm:py-6">
<div className="flex flex-col sm:flex-row justify-between items-center gap-4">
<p className="text-gray-400 text-xs sm:text-sm text-center sm:text-left order-2 sm:order-1">
Copyright © 2025 LogiQuest All Rights Reserved
Copyright © {new Date().getFullYear()} LogiQuest All Rights Reserved
</p>
<div className="flex flex-wrap justify-center sm:justify-end gap-4 sm:gap-6 order-1 sm:order-2">
<a
href="#"
className="text-gray-400 hover:text-cyan-400 transition-colors text-xs sm:text-sm"
>
About us
</a>
<a
href="#"
className="text-gray-400 hover:text-cyan-400 transition-colors text-xs sm:text-sm"
>
Terms & Conditions
</a>
<a
href="#"
className="text-gray-400 hover:text-cyan-400 transition-colors text-xs sm:text-sm"
>
Contact us
</a>
<a
href="#"
className="text-gray-400 hover:text-cyan-400 transition-colors text-xs sm:text-sm"
>
Privacy policy
</a>
{bottomLinks.map((link) => (
<a
key={link}
href="#"
className="text-gray-400 hover:text-cyan-400 transition-colors text-xs sm:text-sm"
>
{link}
</a>
))}
</div>
</div>
</div>
</div>
</footer>
);
}
}
14 changes: 7 additions & 7 deletions src/components/RecentActivity.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,29 +98,29 @@ export const RecentActivity = ({ activities }: Props) => {
<div className="grid grid-cols-[auto_1fr] gap-x-6 gap-y-1 text-sm text-gray-400">
{/* Row 1: Group Size */}
<div className="flex items-center gap-2">
<img src="/call.svg" alt="call" className="w-4" />
<img src="/users.svg" alt="" className="w-4" />
</div>
<div className="flex justify-end gap-2 items-center">
<span>{activity.groupSize}</span>
<span className="text-yellow-500">🏆</span>
<span className="text-yellow-500">{activity.coins.gold}</span>
</div>

{/* Row 2: Participants */}
<div className="flex items-center gap-2">
<img src="/audience.svg" alt="audience" className="w-4" />
<img src="/audience.svg" alt="" className="w-4" />
</div>
<div className="flex justify-end gap-2 items-center">
<span>{activity.participants}</span>
<span className="text-yellow-500">🏆</span>
<span className="text-yellow-500">{activity.coins.gold}</span>
</div>

{/* Row 3: Coins & Earnings */}
<div className="flex items-center gap-1">
<img src="/50-50.svg" alt="50:50" className="w-10" />
<img src="/coins.svg" alt="" className="w-4" />
</div>
<div className="flex justify-end gap-2 items-center">
<span>{activity.earnings}</span>
<span className="text-yellow-500">🏆</span>
<span className="text-red-500">{activity.coins.red}</span>
</div>
</div>
</div>
Expand All @@ -129,4 +129,4 @@ export const RecentActivity = ({ activities }: Props) => {
</div>
</section>
);
};
};