feat(mobile): token detail screen - #588
Open
kaylachi wants to merge 1 commit into
Open
Conversation
Add a per-token screen at token/[id] — the destination when tapping an asset row. The route id identifies the asset (XLM for native, CODE:ISSUER otherwise); `parseAssetId` turns it back into a code + issuer. `fetchTokenDetail` reads the held balance and the account's payments from Horizon, and `filterTokenActivity` narrows those to just the transfers touching this asset (honouring the issuer, and including account funding for XLM). `lib/price.ts` ports the best-effort Lens price lookup, so the screen shows balance, an approximate USD value, and the per-asset transfer history — degrading to 'Price unavailable' when the oracle can't answer. Closes Miracle656#463
|
@kaylachi is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@kaylachi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the per-token detail screen (backlog #35 / #463) — the focused destination when tapping an asset row: a single asset's balance, price, and its own transfer history, mirroring the web token route.
Added
app/token/[id].tsx— the screen. The route id identifies the asset (XLMfor native,CODE:ISSUERfor a classic asset). Shows balance, an approximate USD value + unit price, and the per-asset transfer list, with loading / no-wallet / empty / error states.lib/token.ts—parseAssetId(id)(route segment → code + optional issuer),fetchTokenDetail(publicKey, code, issuer)(held balance + payments from Horizon; unfunded reads as zero), and the purefilterTokenActivitythat narrows a payment page to just the operations touching the asset — honouring the issuer and including account-funding for XLM.lib/price.ts— best-effort Lens oracle price lookup (native port of the webfetchPrice); any 402 / timeout / unknown pair degrades to 'Price unavailable' rather than blocking the screen.Testing
tsc --noEmit✅jest lib/__tests__/token.test.ts✅ (6/6 — id parsing incl. percent-encoding, native-vs-credit filtering, issuer matching, wrong-issuer exclusion)Closes #463