Revert PR #367 blob read surface#373
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8cbf8669^..55d3d214) as one feature unitGET/HEAD /blobendpoint, CLIblob get/statcommands, wire/OpenAPI surface, validators, dependencies, tests, and user documentation introduced by that PRWhy
PR #367 introduced a major public engine, HTTP, and CLI feature without the RFC governance agreement required for changes of this scope. Keeping selected pieces would preserve an architecture and contract that were never approved. This exact revert restores the governance boundary; any successor blob-delivery design should return through the RFC process before implementation.
Impact
The public blob download/stat feature added by #367 is removed. Existing pre-#367 blob behavior remains, including
Omnigraph::read_bloband external-URI materialization. RFC-026 B1 also remains intact; its URI-backed blob materialization concern is separate and is not attributed to #367.Validation
cargo test --workspace --lockedcargo test -p omnigraph-engine --features failpoints --test memwal_stream --locked(24/24)cargo test -p omnigraph-engine --test forbidden_apis --test lance_surface_guards --locked(40/40)cargo test -p omnigraph-server --test openapi --locked(84/84)scripts/check-agents-md.shcargo metadata --locked --no-depsgit diff --checkGreptile Summary
This PR restores the blob behavior that existed before PR #367. The main changes are:
Omnigraph::read_blobAPI.Confidence Score: 4/5
Blob-bearing create and overwrite operations can commit invalid persistent state, so these paths need fixes before merging.
crates/omnigraph/src/table_store.rs
Important Files Changed
read_blobmethod using LanceBlobFile.Reviews (1): Last reviewed commit: "Revert PR #367 blob read surface" | Re-trigger Greptile
Context used: