Add hfb_pwn dataset and doorsnedes GeoJSON to mockup data#62
Merged
Conversation
Register hfb_pwn (horizontal flow barriers / sheet pile walls, v1.0.0) in repository.yaml and add its mockup (hfb_pwn.geojson + generator). Add doorsnedes.geojson (converted from doorsnedes.gpkg, EPSG:28992) to the doorsnedes_nh mockup so model scripts can read the cross-section lines as GeoJSON. Add test_geojson_content.py asserting required property columns and a CRS for the drains_pwn and hfb_pwn GeoJSON artifacts. Fix the yamale extent rule (length= is ignored; use min/max=4) and normalize path separators in the mockup folder-structure test so it also passes on Windows.
Pre-existing lint failure surfaced by this PR's lint job; groups the stdlib zoneinfo import with the other stdlib imports. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the mockup data that the PWN model-2 script (
modelscripts/09pwnmodel2/01_pwnmodel2.py) needs. That model's CI installsnhflodatafrommainand, withNHFLODATA_LOCATIONunset, reads the mockup data bundled in the package — so every dataset the script references must be registered and have mockup data onmain.hfb_pwn(horizontal flow barriers / sheet pile walls) v1.0.0 inrepository.yaml, with mockup (hfb_pwn.geojson+ generator).doorsnedes.geojsontodoorsnedes_nh/v1.0.0, converted fromdoorsnedes.gpkg(RD / EPSG:28992 preserved, matching thelakes_pwn.geojsonconvention). The model reads the cross-section lines as GeoJSON.Tests
tests/test_geojson_content.py: asserts required property columns + a CRS for thedrains_pwnandhfb_pwnGeoJSON artifacts.schema_repository.yaml: yamale ignoreslength=on alist(); enforce exactly-4extentviamin/max.test_mockup_folder_structure.py: normalize path separators so it also passes on Windows.Local run:
5 passed, 2 xfailed.Note
doorsnedes.gpkgis left in place (the forbidden-geopackage test isxfail); it can be dropped in a follow-up once no consumer reads it.