Drop non-ICAS/IKIEF panden instead of raising#42
Open
bdestombe wants to merge 1 commit into
Open
Conversation
get_oppervlakte_pwn_shapes raised when a pand's Naam matched neither "ICAS" nor "IKIEF". The oppervlaktewater_pwn_shapes_panden v1.0.1 dataset contains a "VIJVER" feature (TYPE null) that carries neither name, which made 09pwnmodel2 fail on the mockup data in CI. Since the RIV package represents only the ICAS/IKIEF infiltration panden, filter to those and drop any other features with a warning rather than raising.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a 09pwnmodel2 CI blocker: get_oppervlakte_pwn_shapes raised when a pand's Naam matched neither 'ICAS' nor 'IKIEF'. The oppervlaktewater_pwn_shapes_panden v1.0.1 dataset has a 'VIJVER' feature (TYPE null) that carries neither name, crashing 01_pwnmodel2.py at the panden step on mockup data. Since the RIV package represents only ICAS/IKIEF infiltration panden, filter to those and drop other features with a warning instead of raising. Real data (all ICAS/IKIEF) is unchanged. This is the remaining CI blocker not covered by the doorsnedes/postprocessing work (fix-09pwnmodel2-doorsnedes-and-postprocessing + add-postprocessing-module #40).