Skip to content

(chore) pin dependencies for workflows and Docker base images#238

Open
smoy wants to merge 2 commits into
NVIDIA:mainfrom
smoy:chore/pin-dependencies
Open

(chore) pin dependencies for workflows and Docker base images#238
smoy wants to merge 2 commits into
NVIDIA:mainfrom
smoy:chore/pin-dependencies

Conversation

@smoy

@smoy smoy commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Addressing two of the three issues from ossf/scorecard

Warn: GitHub-owned GitHubAction not pinned by hash: .github/workflows/ci.yml:45
Warn: GitHub-owned GitHubAction not pinned by hash: .github/workflows/ci.yml:71

Warn: containerImage not pinned by hash: Dockerfile:1
Warn: containerImage not pinned by hash: Dockerfile:9: pin your Docker image by updating python:3.12-slim-bookworm to python:3.12-slim-bookworm@sha256:8a7e7cc04fd3e2bd787f7f24e22d5d119aa590d429b50c95dfe12b3abe52f48b
Warn: pipCommand not pinned by hash: Dockerfile:7

@rng1995 rng1995 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Automated SkillSpector Review]

Approved. Both checkout uses are pinned to the immutable v4.2.2 commit, and both Docker stages pin the same immutable Python image digest. The diff is limited to supply-chain pinning and introduces no runtime/schema change. Current Python jobs fail formatting only in unchanged mcp_least_privilege.py, a known mainline drift outside this PR; DCO passes.

@rng1995

rng1995 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Fix linting issues @smoy

smoy added 2 commits July 10, 2026 13:38
Signed-off-by: Steven Moy <github@stevenmoy.com>
Signed-off-by: Steven Moy <github@stevenmoy.com>
@smoy smoy force-pushed the chore/pin-dependencies branch from 69a69bc to 9b7546c Compare July 10, 2026 20:38
@smoy smoy requested a review from rng1995 July 10, 2026 20:38
@smoy

smoy commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Fix linting issues @smoy

rebsed from upstream.

make line is clean now

 make lint              
Running ruff...
ruff check src/ tests/
All checks passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants