feat(analyzer): reduce false positive for emoji-zwj-sequence#260
Open
badnoodle wants to merge 2 commits into
Open
feat(analyzer): reduce false positive for emoji-zwj-sequence#260badnoodle wants to merge 2 commits into
badnoodle wants to merge 2 commits into
Conversation
Signed-off-by: Yangnian <ydyangnian@163.com>
rng1995
requested changes
Jul 9, 2026
rng1995
left a comment
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
[Automated SkillSpector Review]
Requesting changes. The emoji carve-out misses common valid ZWJ sequences containing skin-tone modifiers or VS16, and the PR adds no regressions. Handle the full emoji sequence around ZWJ, add representative positive/negative tests, declare regex as a direct dependency, and run formatting.
… unit test Signed-off-by: Yangnian <ydyangnian@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259 , check the valid Emoji ZWJ sequences to reduce false positive