Skip to content

Update FE to 1.25#3139

Open
cyanguwa wants to merge 1 commit into
NVIDIA:mainfrom
cyanguwa:update_fe1.25
Open

Update FE to 1.25#3139
cyanguwa wants to merge 1 commit into
NVIDIA:mainfrom
cyanguwa:update_fe1.25

Conversation

@cyanguwa

@cyanguwa cyanguwa commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR updates 3rdparty/cudnn-frontend to v1.25.0.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

See Description.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
@cyanguwa cyanguwa requested a review from KshitijLakhani June 22, 2026 19:14
@cyanguwa

Copy link
Copy Markdown
Collaborator Author

/te-ci

@cyanguwa cyanguwa added the 2.17 label Jun 22, 2026
@greptile-apps

greptile-apps Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the 3rdparty/cudnn-frontend submodule from v1.24.0 (c4a97621) to v1.25.0 (e46d7082), continuing a regular upgrade cadence (1.21 → 1.23 → 1.24 → 1.25) seen in the repository's git history.

  • The diff is a single submodule pointer change with no modifications to TransformerEngine source files, build scripts, or API call sites.

Confidence Score: 5/5

Safe to merge — the change is a single submodule pointer bump with no modifications to any TransformerEngine source, build, or test files.

The entire diff is one line: the submodule commit hash in .gitmodules-tracked 3rdparty/cudnn-frontend moves from v1.24.0 to v1.25.0. No TE API call sites, CMake files, or headers were touched, and the upgrade follows the project's established regular cadence. The cuDNN Frontend library is header-only and loaded dynamically at runtime, so the blast radius of a bad bump is contained and reversible.

No files require special attention.

Important Files Changed

Filename Overview
3rdparty/cudnn-frontend Submodule pointer updated from v1.24.0 (c4a97621) to v1.25.0 (e46d7082); no TransformerEngine source changes accompany the bump.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[TransformerEngine Build] --> B[CMakeLists.txt\ntransformer_engine/common]
    B --> C[3rdparty/cudnn-frontend\ninclude/]
    C -->|before PR| D[v1.24.0\nc4a97621]
    C -->|after PR| E[v1.25.0\ne46d7082]
    B --> F[NV_CUDNN_FRONTEND_USE_DYNAMIC_LOADING\ncompile definition]
    E --> G[cuDNN Runtime\nnvidia-cudnn shared library]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[TransformerEngine Build] --> B[CMakeLists.txt\ntransformer_engine/common]
    B --> C[3rdparty/cudnn-frontend\ninclude/]
    C -->|before PR| D[v1.24.0\nc4a97621]
    C -->|after PR| E[v1.25.0\ne46d7082]
    B --> F[NV_CUDNN_FRONTEND_USE_DYNAMIC_LOADING\ncompile definition]
    E --> G[cuDNN Runtime\nnvidia-cudnn shared library]
Loading

Reviews (1): Last reviewed commit: "Update FE to 1.25" | Re-trigger Greptile

@KshitijLakhani KshitijLakhani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge post successful CI !
Thanks for working through the updating process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants