review: Verify function-like macro expansion#33
Merged
Conversation
Review findings that reason from the unexpanded spelling of a function-like macro can misinterpret a formal parameter as a literal token. This can produce false positives even when normal preprocessing substitutes the intended argument. A protected fast-review finding then survives unless a specialist challenges it. Require token-by-token expansion across the fast review, execution specialist, false-positive guidance, and findings validator. Cover formal parameter substitution, nested rescanning, member-access punctuation, stringification, token pasting, and variadic arguments. Require decisions to use the final expanded token stream. Add regression assertions for every prompt path so the expansion requirements cannot be dropped independently. Signed-off-by: Andrea Righi <arighi@nvidia.com>
nirmoy
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review findings that reason from the unexpanded spelling of a function-like macro can misinterpret a formal parameter as a literal token. This can produce false positives even when normal preprocessing substitutes the intended argument. A protected fast-review finding then survives unless a specialist challenges it.
Require token-by-token expansion across the fast review, execution specialist, false-positive guidance, and findings validator. Cover formal parameter substitution, nested rescanning, member-access punctuation, stringification, token pasting, and variadic arguments. Require decisions to use the final expanded token stream.
Add regression assertions for every prompt path so the expansion requirements cannot be dropped independently.