DNI: DEBUG: PR to debug/fix CPU CI failures - #400
Draft
ksheth-dev wants to merge 2 commits into
Draft
Conversation
Split PyNvHardwareEncoder and its ABGR-frame / NAL-scan helpers out of encoders.py into a sibling nvenc.py that owns the top-level PyNvVideoCodec import. encoders.py no longer touches PyNvVideoCodec at module load; select_encoder probes availability via importlib.util.find_spec (no side effects) and imports nvenc only when a hardware backend is actually about to be constructed. The Lingbot WebRTC path resolves to DefaultRTCEncoder in the base manager and never enters the hardware branch, so its process no longer loads PyNvVideoCodec at all — sidestepping a silent early-exit observed during the Lingbot server launch when PyNvVideoCodec was importable. Tests updated to patch _pynvvideocodec_installed and inject a fake PyNvVideoCodec into sys.modules so nvenc's top-level import binds to the mock. The GPU smoke test's imports follow the split. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ksheth-dev
force-pushed
the
pull-request/999999
branch
from
July 29, 2026 09:09
3ce03df to
b65f4c8
Compare
ksheth-dev
force-pushed
the
dev/ksheth/pynvvideocodec_v2
branch
4 times, most recently
from
July 29, 2026 11:21
bec5ea2 to
6434238
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.