Refine benchmark reports and fix FFmpeg stderr draining - #405
Open
jarcherNV wants to merge 4 commits into
Open
Conversation
Fold derived benchmark summary metrics into their base metric rows so the HTML report shows the median-focused view developers expect. Constrain the scenario table layout and collapse long command strings behind a details control to avoid wide commands crowding adjacent columns. Drain FFmpeg stderr concurrently while streaming video frames to stdin to avoid subprocess pipe-buffer deadlocks during MP4 writing.
Contributor
Greptile SummaryRefines benchmark report presentation and prevents FFmpeg stderr pipe deadlocks.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant Runner
participant FFmpeg
participant DrainThread
Runner->>FFmpeg: Stream video frames through stdin
FFmpeg-->>DrainThread: Emit stderr diagnostics
DrainThread->>DrainThread: Accumulate stderr chunks
Runner->>FFmpeg: Close stdin and wait
Runner->>DrainThread: Join
DrainThread-->>Runner: Complete stderr output
Reviews (4): Last reviewed commit: "Avoid overwriting base benchmark metrics" | Re-trigger Greptile |
Record metric-summary provenance in benchmark manifests and use it when rendering HTML reports, so derived perf-summary metrics are only folded when they came from parsed log-summary records. This keeps median-focused report output for known benchmark perf summaries while preserving custom metric names such as latency_median_s from stats JSON.
Record parser provenance for log-derived benchmark metrics and carry it into metric_summary_metadata so the HTML report can distinguish generated perf summary metrics from arbitrary profile metrics. Only fold suffix-shaped metrics when they came from the perf-summary parser, preserving profile e2e metric names such as latency_median_s in reports.
Make report metric folding explicitly skip existing base metric rows so a perf-summary-derived value such as generate_s_median_s cannot replace the median computed from generate_s samples. Add regression coverage for conflicting base and derived medians, and apply ruff formatting expected by the CPU CI pre-commit run.
jarcherNV
enabled auto-merge
August 1, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fold derived benchmark summary metrics into their base metric rows so the HTML report shows the median-focused view developers expect. Constrain the scenario table layout and collapse long command strings behind a details control to avoid wide commands crowding adjacent columns.
Drain FFmpeg stderr concurrently while streaming video frames to stdin to avoid subprocess pipe-buffer deadlocks during MP4 writing.