Cherrypick/release 1.3 main fixes#226
Closed
jingxiang-z wants to merge 16 commits into
Closed
Conversation
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Amber Xue <ambermingxin@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Amber Xue <ambermingxin@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
…auth token is present. (#199) Signed-off-by: Michael O'Neill <miconeil@amazon.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
…#220) Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Amber Xue <ambermingxin@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (91)
📝 WalkthroughWalkthroughThe PR updates build and release tooling, adds stable node UUID handling and enrollment validation, threads a metric scrape interval through config and inventory, reworks metric typing and DCGM wiring, and changes exporter, registry, and persistence-mode behavior. ChangesBuild and packaging
Runtime behavior
Sequence Diagram(s)sequenceDiagram
participant EnrollWithConfigAndMetadata
participant nodeidentity_EnsureNodeUUID as "nodeidentity.EnsureNodeUUID"
participant sqliteState_GetOrCreateNodeUUID as "sqliteState.GetOrCreateNodeUUID"
participant GetOrCreateNodeUUIDMetadata as "GetOrCreateNodeUUIDMetadata"
EnrollWithConfigAndMetadata->>nodeidentity_EnsureNodeUUID: initialize node UUID
nodeidentity_EnsureNodeUUID->>sqliteState_GetOrCreateNodeUUID: GetOrCreateNodeUUID(...)
sqliteState_GetOrCreateNodeUUID->>GetOrCreateNodeUUIDMetadata: create or repair UUID
GetOrCreateNodeUUIDMetadata-->>sqliteState_GetOrCreateNodeUUID: committed UUID
sqliteState_GetOrCreateNodeUUID-->>nodeidentity_EnsureNodeUUID: UUID
nodeidentity_EnsureNodeUUID-->>EnrollWithConfigAndMetadata: UUID
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6eaf5d2022
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| MetadataKeySAKToken = "sak_token" | ||
| MetadataKeyEnrolledAt = "enrolled_at" | ||
| MetadataKeyNodeGroup = "nodegroup" | ||
| MetadataKeyNodeGroup = "node_group" |
There was a problem hiding this comment.
For upgraded agents that enrolled with a node group before this commit, the value is already stored under the old nodegroup key; after this line all readers (GetNodeGroup, the inventory sink, and OTLP resource metadata) look only for node_group, so an upgrade without re-running fleetint enroll --node-group ... silently drops the node group assignment from inventory and telemetry despite the Helm comments saying omitted metadata preserves stored values. Please add a fallback or migration for the legacy key before changing the persisted key.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Documentation