Fix missing nvtx stack and host mem resource by exporting the symbols#3083
Merged
Conversation
📝 WalkthroughWalkthroughThe changes add ChangesExport visibility updates
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This NVIDIA/cuvs#2052 changes default symbol visibility to cuvs from public to hidden. The
raft::memory_tracking_resourcesintroduced in raft earlier now has the host memory resource and nvtx stack range symbols switched to hidden (i.e. private within libcuvs.so). This led to empty nvtx stack name and missing host memory allocations in the .csv file produced byraft::memory_tracking_resources, because two DSO's kept two separate symbols.The current PR explicitly exports those symbols again and fixes the issue.
Analysis
Before the changes, the symbols in the example and in the libcuvs.so are two different entities with different addresses.
After exporting,