PD-3625 Fix spacing, alignment and typography in Names panel#2874
Merged
Conversation
Restructures the published name markup so the label sits outside the <h1> instead of nested inside it with a redundant <p> (also fixes PD-2475's mis-coloured label), restores the label-to-value spacing that a dead CSS selector was silently dropping, centers the visibility icon against its full text block instead of the top line, and applies the $body-large (18px/24px bold) and 14px bold styles called for in the Figma redlines.
Member
|
Task linked: PD-3625 Spacing and alignment in Names panel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.