Update actions/checkout and module version, remove CLI function and documentation#11
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the module’s release/versioning and CI maintenance while removing public-facing documentation/exports for Deploy-OSDCloudCLI. It also introduces a new Deploy-OSDCloudCLI implementation under OSDCloud/private/, which conflicts with the stated goal of removing the CLI function unless the intent is only to unexport it.
Changes:
- Bump
OSDCloudmodule version to26.7.25.1and removeDeploy-OSDCloudCLIfromFunctionsToExport. - Remove
Deploy-OSDCloudCLIhelp content (external help XML entry and markdown doc). - Update catalog update workflows to use
actions/checkout@v5.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| OSDCloud/private/Deploy-OSDCloudCLI.ps1 | Adds a new private Deploy-OSDCloudCLI function implementation (note: contradicts “remove CLI function” unless meant to be internal-only). |
| OSDCloud/OSDCloud.psd1 | Bumps module version and removes Deploy-OSDCloudCLI from exported functions list. |
| OSDCloud/en-US/OSDCloud-help.xml | Removes the external help entry for Deploy-OSDCloudCLI. |
| OSDCloud/docs/Deploy-OSDCloudCLI.md | Deletes the markdown documentation page for Deploy-OSDCloudCLI. |
| .github/workflows/update-catalog-microsoft.yaml | Updates checkout action to actions/checkout@v5. |
| .github/workflows/update-catalog-lenovo.yaml | Updates checkout action to actions/checkout@v5. |
| .github/workflows/update-catalog-hp.yaml | Updates checkout action to actions/checkout@v5. |
| .github/workflows/update-catalog-dell.yaml | Updates checkout action to actions/checkout@v5. |
Comment on lines
24
to
28
| # --- Exports --- | ||
| FunctionsToExport = @( | ||
| 'Deploy-OSDCloud', | ||
| 'Deploy-OSDCloudCLI', | ||
| 'Get-OSDCloudCache', | ||
| 'Get-OSDCloudModulePath', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the actions/checkout version to v5 in workflow files, update the module version to 26.7.25.1, and remove the Deploy-OSDCloudCLI function along with its documentation.