Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions sync/last_live_r_parity_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,17 @@
- Plan: `sync/last_r_api_plan.json`
- R checkout: `upstream/NNS`
- Fresh cache requested: `False`
- Skip install: `False`
- Live R recompute: `True`
- Skip install: `True`
- Live R recompute: `False`

## Result: live R parity diverged
## Result: manual review required

Mapped parity tests recomputed every R value from the freshly installed live R NNS and the Python implementation did not match. Public Python behavior differs from live R at the recorded commit.
The plan reports unmapped R files. A human must extend `sync/r_api_map.json` before automated parity can run:

Failing command: `/opt/hostedtoolcache/Python/3.11.15/x64/bin/python -m pytest -q -n 0 tests/parity/test_practical_examples.py tests/parity/test_r13_smoke.py`
Exit status: `1`
- `R/Normalization.R`

## Workflow step outcome

- `run_live_r_parity_for_changed_api.py` step outcome: `failure`
- Fresh cache requested: `false`
- DESCRIPTION changed: `false`
18 changes: 10 additions & 8 deletions sync/last_r_api_inspection.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,27 @@

## Changed files

- `R/ARMA.R`
- `R/Normalization.R`
- `tests/testthat/test_Normalization.R`

## Affected Python modules

- `src/nns/arma.py`
- None mapped

## Parity tests to run

- `tests/parity/test_practical_examples.py`
- `tests/parity/test_r13_smoke.py`
- None mapped

## Cache scope

- `NNS.ARMA`
- `NNS.ARMA.optim`
- `NNS.VAR`
- None mapped

## Required actions

- Fresh cache required: `False`
- Export review required: `False`
- Unmapped R files present: `False`
- Unmapped R files present: `True`

## Unmapped R files

- `R/Normalization.R`
24 changes: 9 additions & 15 deletions sync/last_r_api_plan.json
Original file line number Diff line number Diff line change
@@ -1,22 +1,16 @@
{
"changed_files": [
"R/ARMA.R"
],
"affected_python_modules": [
"src/nns/arma.py"
],
"parity_tests": [
"tests/parity/test_practical_examples.py",
"tests/parity/test_r13_smoke.py"
],
"cache_scope": [
"NNS.ARMA",
"NNS.ARMA.optim",
"NNS.VAR"
"R/Normalization.R",
"tests/testthat/test_Normalization.R"
],
"affected_python_modules": [],
"parity_tests": [],
"cache_scope": [],
"requires_fresh_cache": false,
"requires_export_review": false,
"has_unmapped_r_files": false,
"unmapped_r_files": [],
"has_unmapped_r_files": true,
"unmapped_r_files": [
"R/Normalization.R"
],
"warnings": []
}
Loading