feat(repositories): implementación de la capa de repositorios y abstracción de acceso a datos#7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Este PR introduce una capa de repositorios para centralizar el acceso a datos con SQLAlchemy, aislando la lógica CRUD de controladores/servicios y estableciendo una base común reutilizable.
Changes:
- Se agrega
BaseRepositorycon operaciones CRUD genéricas usandodb.session. - Se crean repositorios específicos por entidad que heredan de
BaseRepositorye inyectan su modelo. - Se expone una fachada de importación en
app.repositoriesvía__init__.pypara uso directo desde capas superiores.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/app/repositories/base_repository.py | Implementa el repositorio base con CRUD y manejo de transacciones (commit/rollback). |
| backend/app/repositories/init.py | Expone los repositorios específicos como API pública del paquete. |
| backend/app/repositories/category_repository.py | Repositorio específico para Category basado en BaseRepository. |
| backend/app/repositories/city_repository.py | Repositorio específico para City basado en BaseRepository. |
| backend/app/repositories/skill_repository.py | Repositorio específico para Skill basado en BaseRepository. |
| backend/app/repositories/job_repository.py | Repositorio específico para Job basado en BaseRepository. |
| backend/app/repositories/job_skill_repository.py | Repositorio específico para JobSkill basado en BaseRepository. |
| backend/app/repositories/user_repository.py | Repositorio específico para User basado en BaseRepository. |
| backend/app/repositories/alert_repository.py | Repositorio específico para Alert basado en BaseRepository. |
| backend/app/repositories/trend_snapshot_repository.py | Repositorio específico para TrendSnapshot basado en BaseRepository. |
| backend/app/repositories/backup_repository.py | Repositorio específico para Backup basado en BaseRepository. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+20
to
+22
| except Exception as e: | ||
| db.session.rollback() | ||
| raise e |
Comment on lines
+32
to
+34
| except Exception as e: | ||
| db.session.rollback() | ||
| raise e |
Comment on lines
+44
to
+46
| except Exception as e: | ||
| db.session.rollback() | ||
| raise e No newline at end of file |
Comment on lines
+10
to
+11
| def get_by_id(self, id): | ||
| return db.session.get(self.model, id) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature/repository-layer
Descripción
Se integra el patrón de diseño Repositorio para encapsular y centralizar la interacción con la base de datos mediante SQLAlchemy. Esto establece una barrera arquitectónica que aísla las consultas de los controladores y servicios, garantizando escalabilidad y mantenimiento limpio.
Decisiones técnicas integradas:
BaseRepository): Centraliza las operaciones CRUD fundamentales (get_all,get_by_id,create,update,delete) e incorpora gestión de transacciones segura (rollbacks automáticos ante excepciones) para proteger la integridad de los datos.CategoryRepository,CityRepository,SkillRepository,JobRepository,JobSkillRepository,UserRepository,AlertRepository,TrendSnapshotRepository,BackupRepository) que heredan la lógica del constructor genérico inyectando su modelo correspondiente, evitando duplicidad de código.__init__.py): Actúa como fachada del módulo, exponiendo de manera limpia únicamente las 9 clases instanciables y manteniendo elBaseRepositoryoculto para evitar su uso directo en capas superiores.Tipo de cambio
Cómo probar
git checkout develop && git pull origin developcd backendflask --app run shellexit().Checklist