Skip to content

Sanitize logs #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shellster wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sanitize logs #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18ab865
strip sensitive values from logging
Mar 11, 2026
39ef854
clean-up comment
Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions kotlix/src/commonMain/kotlin/app/octocon/kotlix/Socket.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,14 @@ abstract class SocketCommon(
return ref.toString()
}

/** A nullable-aware wrapper around the [logger] lambda */
/** A nullable-aware wrapper around the [logger] lambda that sanitizes sensitive data */
internal fun logItems(body: String) {
logger?.invoke(body)
var sanitized = body
// Redact system IDs: "system:123" -> "system:<redacted>"
sanitized = sanitized.replace(Regex("""system:[^"]+"""), "system:<redacted>")
// Redact token values in JSON: "token":"..." -> "token":"<redacted>"
sanitized = sanitized.replace(Regex(""""token":"[^"]*"""), """"token":"<redacted>""")
logger?.invoke(sanitized)
}

/**
Expand Down Expand Up @@ -583,4 +588,4 @@ fun buildEndpointUrl(
}

return urlBuilder.build()
}
}