Fix reported KOS stabilisation issues - #2078
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When KOS was running against a deployment with a HPA, there were 2 reported issues:
This change aligns most workload-level resources with the logic that GitOps engine uses, as they have worked out more edge cases than we have. This leads to the checks being more reliable, and we also match KOS with KLOS, which implements the GitOps engine entirely.
We also add a cache for child objects to each check (invalidated for each check run) so that we don't list all resources in the cluster multiple times for any given check, which caused slow check speeds.