Change test to generate uft8 file - #2079
Merged
Merged
Conversation
The previous implimentation was fraigile in that the non-ASCII-named zip was a checked-in binary fixture that had to survive Windows build → zip artifact → TeamCity download → Linux agent unpack before the test ever ran. That whole chain is outside the codebase's control (or ours to fully trust), which is exactly why it broke intermittently, and only on the ephemeral Amazon Linux 2 agents.
zentron
force-pushed
the
robe/fix-utf8-test
branch
from
July 23, 2026 21:12
133ed91 to
145fa9f
Compare
zentron
marked this pull request as ready for review
July 23, 2026 21:33
APErebus
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implimentation was fraigile in that the non-ASCII-named zip was a checked-in binary fixture that had to survive Windows build → zip artifact → TeamCity download → Linux agent unpack before the test ever ran. That whole chain is outside the codebase's control, which is exactly why it broke intermittently, and only on the ephemeral Amazon Linux 2 agents.