Skip to content

fix(elasticsearch): gate remaining tasks on check mode #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oddly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(elasticsearch): gate remaining tasks on check mode #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roles/elasticsearch/handlers/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
loop: "{{ groups[elasticstack_kibana_group_name] | default([]) }}"
run_once: true
when:
- not ansible_check_mode
- elasticstack_full_stack | bool
- "not 'renew_ca' in ansible_run_tags"
- "not elasticstack_ca_will_expire_soon | bool"
Expand Down
5 changes: 3 additions & 2 deletions roles/elasticsearch/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,14 +558,15 @@
# so the finding is a false positive

- name: Handle cluster setup without security
when: not elasticsearch_security | bool
when:
- not elasticsearch_security | bool
- not ansible_check_mode
block:
- name: Check for cluster status without security
ansible.builtin.uri:
# kics-scan ignore-line
url: "http://{{ elasticsearch_api_host }}:{{ elasticstack_elasticsearch_http_port }}/_cluster/health?pretty"
register: elasticsearch_cluster_status
ignore_errors: "{{ ansible_check_mode }}"
until: ((elasticsearch_cluster_status.json | default({})).status | default('')) in ['green', 'yellow']
retries: 30
delay: 10
Expand Down