fix: obfuscation - #66
Merged
Merged
Conversation
Closes: #63
There was a problem hiding this comment.
🟢 Ready to approve
The changes directly address the reported obfuscation bug with targeted code updates and expanded test coverage.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Fixes the obfuscation behavior used in item viewing flows so that secrets are no longer partially revealed (e.g., letters/symbols), and adds configurability for which characters (like formatting spaces) remain visible. This aligns with Issue #63, where obfuscation previously only applied to digits in viewing screens.
Changes:
- Update
ObfuscatedString.hiddento obfuscate all non-preserved characters (not just digits), with an opt-inpreservedCharsset. - Expand unit tests to cover default behavior, configured preserved characters, and mixed content cases.
- Update credit card viewing code to preserve formatting spaces while still revealing the configured suffix.
File summaries
| File | Description |
|---|---|
| feature/item/view/src/test/kotlin/de/davis/keygo/feature/item/view/login/model/ObfuscatedStringTest.kt | Adds/updates tests to validate new obfuscation + preservation behavior. |
| feature/item/view/src/main/kotlin/de/davis/keygo/feature/item/view/login/model/ObfuscatedString.kt | Changes obfuscation algorithm and introduces preservedChars configuration. |
| feature/item/view/src/main/kotlin/de/davis/keygo/feature/item/view/creditcard/ViewCreditCardViewModel.kt | Preserves spaces in formatted card numbers while obfuscating content. |
| feature/item/view/src/main/kotlin/de/davis/keygo/feature/item/view/creditcard/ViewCreditCardContent.kt | Updates preview to match new obfuscation configuration for card numbers. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #63