Skip to content

review operation so it can be a dict or a list#170

Open
alexandrecuer wants to merge 4 commits into
mainfrom
review_operation
Open

review operation so it can be a dict or a list#170
alexandrecuer wants to merge 4 commits into
mainfrom
review_operation

Conversation

@alexandrecuer

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/idfhub/hvac24_1_0.py Outdated
Plantequipmentoperationschemes(
operations = []
if isinstance(loop_machines, dict):
for operation_type, machines in loop_machines:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should solve #164

@alexandrecuer alexandrecuer Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So a possible operation conf in loop can be :

operation:
  uncontrolled: [borehole]
  cooling : [fcu_RDC_coil_cooling_water, fcu_RPLUS1_coil_cooling_water]

@alexandrecuer alexandrecuer Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And

operation: [borehole, fcu_RDC_coil_cooling_water, fcu_RPLUS1_coil_cooling_water]

Still works

But all loop equipments will be classified the same way, as per Loop_Type indication

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation to amend if this is merged

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To create a fan coil unit (fcu) using a coil_cooling_water named fcu_RDC_coil_cooling_water, the user just declares fcu_RDC in the yml key equipments

  • then fcu_RDC becomes a zone equipment
  • and fcu_RDC_coil_cooling_water a plant equipment, but referenced under the fcu_RDC key, that permits not too change much the code but for the user, it can be an intellectual mess

so actually, you cannot declare things like that :

operation:
  uncontrolled: [borehole]
  cooling : [fcu_RDC_coil_cooling_water, fcu_RPLUS1_coil_cooling_water]

the correct way should be

operation:
  uncontrolled: [borehole]
  cooling : [fcu_RDC, fcu_RPLUS1]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAUTION :

the code is a nice improvment, but coilcoolingwater is not a good use case : the coil cannot go in a plantequipmentlist, it is a consomation object, not a production one, even if you connect it on a plantloop !!!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le PlantEquipmentOperation ne pilote que le Supply Side.

Comment thread src/idfhub/hvac24_1_0.py Outdated
Comment thread src/idfhub/hvac24_1_0.py Outdated
Comment thread src/idfhub/hvac24_1_0.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant