fix: implement retry logic for ComponentInformation to handle transient errors#118
Merged
Merged
Conversation
…nt errors Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
travisbcotton
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces improved resiliency and reliability to SMD client interactions, particularly during high-load scenarios such as boot storms. The main enhancements include adding retry logic with exponential backoff for component information lookups, updating the SMD client interface, and tuning HTTP client configuration for better performance.
Resiliency Improvements:
ComponentInformationWithRetrymethod toSMDClientthat wrapsComponentInformationwith exponential backoff retry logic for transient network errors and timeouts, improving reliability during SMD overloads.isRetryableErrorhelper function to determine which errors should trigger a retry, covering timeouts, network errors, and common HTTP error codes like 429 and 503.MetaDataHandlerinmetadata_handlers.goto useComponentInformationWithRetrywith up to 3 attempts instead of a single call toComponentInformation.Interface and Testing Updates:
SMDClientInterfaceto include the newComponentInformationWithRetrymethod, ensuring all clients (including fakes) conform to the updated contract.ComponentInformationWithRetryinFakeSMDClientfor testing.HTTP Client Configuration:
DisableKeepAlivesfromtruetofalseto allow HTTP keep-alive connections, improving efficiency under load.Type of Change
For more info, see Contributing Guidelines.