feat: expose dizzy dithering in the service selectors - #88
Merged
Conversation
epaper-dithering 6.0.0 added DitherMode.DIZZY (value 9), error diffusion with a pseudo-random traversal instead of a raster scan. py-opendisplay re-exports DitherMode straight from epaper_dithering, and the service schemas build their validators from the enum via _str_to_int_enum, so "dizzy" was already accepted by upload_image and drawcustom. It was just missing from the hand-maintained UI metadata, which made it invisible in the Home Assistant service picker. Add it to both select option lists in services.yaml, add the label to strings.json, and document it in the drawcustom option table. Both selectors now match DitherMode element for element in enum order. Translations regenerate from strings.json via the translate workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
DitherMode.DIZZY(epaper-dithering 6.0.0) in the HA UI.py-opendisplay already passes it through: it re-exports
DitherModefromepaper_dithering, and_str_to_int_enumbuilds the service validators from the enum, so"dizzy"was already accepted. It was just missing from the hand-maintained UI metadata, making it invisible in the service picker.services.yaml: added to theupload_imageanddrawcustomoption listsstrings.json: added the selector labeldocs/drawcustom/supported_types.md: documented the valueBoth selectors now match
DitherModeelement for element. Suite passes. Translations regenerate fromstrings.jsonvia the translate workflow.