chore(deps-dev): allow pytest 9.x (bump cap <9 -> <10) - #34
Merged
Conversation
What changed: widen the dev-group pytest range from >=8,<9 to >=8,<10 and re-lock (pytest 8.4.2 -> 9.1.1; no other package moves). The reason comment now records why the old cap existed and why it can go. Why: the <9 cap guarded against the pytest 9.0.3 collection regression (module-level importorskip / skip(allow_module_level=True) conflated SKIPPED entries under the first module, hiding skip reasons in tests/sim/). pytest 9.1.1 fixes it. Supersedes the pytest half of dependabot PRs #29 and #33, both of which also carried a no-op transformers widening (lerobot 0.6.0's transformers-dep extra caps transformers at <5.6.0, so the lock stays at 5.5.4 either way), left the openral_cli.install._GROUPS mirror stale (failing test_install_command), and did not update uv.lock. How tested: full tests/unit suite run locally under pytest 9.1.1 — 4004 passed, 49 skipped in 143s. Skip reasons render per-module and distinct (including tests/unit/test_sim_collection.py, the guard for the original regression), confirming the 9.0.3 conflation behaviour is gone. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Adrian Llopart <adrianllopart@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Widen the
devdependency-group pytest range from>=8,<9to>=8,<10and re-lock.uv.lockmoves pytest8.4.2 -> 9.1.1; no other package moves. The reason comment is rewritten to record why the old cap existed and why it can go.Why
The
<9cap guarded against a real pytest 9.0.3 collection regression: modules usingpytest.importorskip/pytest.skip(allow_module_level=True)at module level emittedERROR: found no collectorsand conflated every SKIPPED entry under the first module, silently hiding skip reasons acrosstests/sim/. pytest 9.1.1 fixes it.This supersedes the pytest half of dependabot PRs #29 and #33 (both closed). Both grouped a no-op transformers widening (
<5.14.0 -> <5.15.0) with the pytest bump —lerobot 0.6.0capstransformers<5.6.0,>=5.4.0on itstransformers-depextra, so the resolver stays on 5.5.x regardless — and both left theopenral_cli.install._GROUPSmirror stale (failingtest_install_command) and shipped nouv.lock. This PR carries only the part that does something.How tested
Full
tests/unitsuite locally under pytest 9.1.1:Skip reasons render per-module and distinct — including
tests/unit/test_sim_collection.py, the guard written for the original regression — confirming the 9.0.3 conflation behaviour is gone.🤖 Generated with Claude Code
https://claude.ai/code/session_01CfTEV5GayAr2bWawR6APgR