Conversation
Contributor
|
🔄 AI PR Review sedang antri di server...
|
Contributor
Author
|
silahkan dicek kembali mas @analisopendesa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

issue # #1656
🎯 Deskripsi
Pull request ini memperbaiki sejumlah rentetan bug pada antarmuka pengguna (UI) halaman publik, secara spesifik pada beberapa widget sidebar (Event, Sinergi Program, Media Sosial, Media Terkait) serta kegagalan rendering pada halaman detail Event.
Penyebab utamanya bervariasi di beberapa lapisan:
OPENdan menggunakangroupByyang membuat format Collection menjadi array berlapis dan sulit diekstrak oleh JavaScript di frontend.event.slugsebagai teks judul event, padahal seharusnyaevent.event_name.media_terkait/alih-alihstorage/media_terkait/), serta tidak adanya perlindungan null (null-safety) jika admin lupa mengunggah logo/gambar, yang memicu error JavaScript (crash).event_detail.blade.phppada@extends('layouts.app ')yang menyebabkan kerangka aplikasi (layout) gagal dimuat (not found).PR ini memperbaiki seluruh anomali tersebut sehingga widget dapat berfungsi lancar, anti-error, serta menata ulang sedikit tampilan detail event agar lebih proporsional.
🛠️ Perubahan yang Dilakukan
1.
app/Models/Event.phpFix — Koreksi query pengambilan data event:
scopeOpen()untuk memfilter event berdasarkan status 'OPEN'.getOpenEvents()agar menjadi Collection tunggal (tidak lagi digroupByberdasarkan tanggal) untuk mempermudah konsumsi JSON pada frontend.2.
themes/opendk/default/resources/views/components/website-data.blade.phpFix — Koreksi integrasi JavaScript pada semua widget pendukung:
event_namebukanslug.{{ asset("media_terkait") }}menjadi{{ asset("storage/media_terkait") }}sehingga logo yang di-upload via admin dapat ter-render dengan sempurna.updateMediaSosial,updateSinergiProgram, danupdateMediaTerkaitsupaya pemanggilanreplace()dan ekstensi URL gambar tidak me-throw error saat data logo di-set kosong (null).3.
themes/opendk/default/resources/views/pages/event/event_detail.blade.phpFix & Refactor — Perbaikan ekstensi layout dan penataan elemen:
@extends.✅ Test Cases yang Diimplementasikan
event_name) dengan benar pada sidebar widget.📸 Cara Menjalankan Uji Coba Manual
📸 Screenshot atau Video