feat(spp_cel_domain): SQL CASE compiler, read-only smart-op lookup, translator cache tests (re-land from #76)#275
feat(spp_cel_domain): SQL CASE compiler, read-only smart-op lookup, translator cache tests (re-land from #76)#275gonzalesedwin1123 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the compilation of CEL ternary expressions into SQL CASE WHEN expressions via the new to_sql_case method, supported by new helper methods in SQLBuilder and a right-associative parsing fix in the CEL parser. Additionally, it updates the _smart_op_domain method to perform read-only lookups for gender labels instead of creating records on the fly, and adds comprehensive unit tests covering the new SQL compilation logic, read-only lookups, and translation cache helpers. There are no review comments to assess, and the changes appear solid and well-tested.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…SQL CASE (from #76) Re-lands the spp_cel_domain portion of reverted PR #76: - SQL CASE support: to_sql_case compiler for CEL ternaries, case_when/ comparison builders, right-associative ternary parsing fix - Read-only smart operator label lookup (no record creation, no sudo during compilation) - Tests for the translation cache helpers tests/__init__.py was merged by hand to keep imports added by later security PRs (#251/#257/#223). Version bumped to 19.0.2.1.0 with a HISTORY entry.
059a52f to
dd1bf96
Compare
Re-lands the spp_cel_domain portion of reverted PR #76 (revert: #271).
Summary
to_sql_case,case_when/comparisongrammar, ternary right-associativity fix in the CEL parser).sudo().create()side effect during lookup)._make_cache_key,invalidate_translation_cache) plus new test suites for CASE compilation and smart-op lookup.tests/__init__.pymerges the new imports with the ones added by security PRs feat: SR DCI server/client end-to-end + CEL metric composition fix #223/security(dci): allowlist external predicate symbols (fields + metrics) #251/security(dci): restrict Data API pull to non-sensitive provider variables #257 (nothing overwritten).Verification
./spp t spp_cel_domain: 621 passed, 0 failed