chore: Move common logic to shared package#325
Draft
hhvrc wants to merge 3 commits into
Draft
Conversation
…mon code Replace the duplicated shared utility/validation/crypto/geo/dynamic-LINQ/ ASP.NET code in Common/ with references to the published packages OpenShock.Internal.Common, OpenShock.Internal.AspNet and OpenShock.Internal.DynamicLinq (pinned at 0.0.1). - Delete 38 now-redundant files (exact duplicates + the PasswordHashingAlgorithm enum + the Cloudflare IP generation, now owned by the package). - Re-point ~150 consumers to the OpenShock.Internal.* namespaces. - OpenShockControllerBase now inherits the package base, keeping API-specific session/cookie/legacy-response helpers. - Split HardLimits: shared limits come from the package, API-specific extras move to a new local ApiHardLimits. - Split IQueryableExtensions: ApplyFilter/ApplyOrderBy from the package, WhereUserIdMatches/WhereIsUserOrPrivileged stay local. - Adapt to package surface changes: CryptoUtils.RandomString rename, OpenShockProblem.WriteAsJsonAsync / OpenShockExceptionHandler now take JsonSerializerOptions (registered JsonOptions.Default in DI), ApplyOrderBy is now static. - Bump BCrypt.Net-Next 4.2.0 -> 4.2.1 (required by OpenShock.Internal.Common). - Drop the 6 Common.Tests files now covered by the packages' own test projects.
|
Ready to review this PR? Stage has broken it down into 12 individual chapters for you: 
Chapters generated by Stage for commit 30e227a on Jun 28, 2026 9:35pm UTC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.