Fix cache-step condition in openvic-sim-build/action.yml#775
Merged
Conversation
Spartan322
changed the title
Change the cache setup condition to correctly check the string input value.
GitHub Actions inputs are strings, so replacing `if: ${{ !inputs.disable-cache }}` with `if: ${{ inputs.disable-cache != 'true' }}` ensures the cache step runs unless the caller explicitly sets disable-cache to 'true'.
This fixes an issue where the cache was never used when disable-cache was omitted or set to other truthy values.
Affects .github/actions/openvic-dl-build/action.yml and all build workflows.
Spartan322
force-pushed
the
fix/action-build-cache
branch
from
ed87433 to
02577dd
Compare
Catylist0
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the cache setup condition to correctly check the string input value. GitHub Actions inputs are strings, so replacing
if: ${{ !inputs.disable-cache }}withif: ${{ inputs.disable-cache != 'true' }}ensures the cache step runs unless the caller explicitly sets disable-cache to 'true'. This fixes an issue where the cache was never used when disable-cache was omitted or set to other truthy values. Affects .github/actions/openvic-dl-build/action.yml and all build workflows.