Fix job pod memory limit multiplier typo (1204 -> 1024)#309
Closed
wesleyjellis wants to merge 1 commit into
Closed
Fix job pod memory limit multiplier typo (1204 -> 1024)#309wesleyjellis wants to merge 1 commit into
wesleyjellis wants to merge 1 commit into
Conversation
The memory limit was computed as MB*1024*1204 instead of MB*1024*1024, inflating every job pod's effective memory limit by ~17.6% over the configured value (e.g. --job-pod-limits-memory=6656 produced ~7.8GiB instead of 6.5GiB). Note this effectively lowers job pod memory limits for existing deployments; jobs that relied on the accidental headroom may start OOMKilling after this lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Author
|
Closing — this was based on a stale clone. The typo was already fixed on main in January 2026 (beads issue opslevel-runner-c7f); current main computes memory limits as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The job pod memory limit was computed as
MemLimit*1024*1204instead ofMemLimit*1024*1024— a digit-swap typo that inflates every job pod's effective memory limit by ~17.6% over the configured value. For example, prod's--job-pod-limits-memory=6656currently produces a ~7.8 GiB limit instead of the intended 6.5 GiB.This lowers effective job pod memory limits for all existing deployments back to their configured values. Any job that has been relying on the accidental headroom may start getting OOMKilled after this rolls out. If we'd rather keep current effective limits, the configured MB values should be bumped ~17.6% in the same release.
Heads up: #308 refactors these lines into a
resources()helper (deliberately preserving this bug) — whichever lands second needs a trivial rebase.🤖 Generated with Claude Code