Skip to content

feat(lib): Bump button v3.3.0, expand button v3.2.0 and navigation button v3.3.0 - #3713

Open
louismaximepiton wants to merge 7 commits into
tokenator-update-tokens-20260722113803from
tokenator-lmp-update-buttons
Open

feat(lib): Bump button v3.3.0, expand button v3.2.0 and navigation button v3.3.0#3713
louismaximepiton wants to merge 7 commits into
tokenator-update-tokens-20260722113803from
tokenator-lmp-update-buttons

Conversation

@louismaximepiton

@louismaximepiton louismaximepiton commented Jul 23, 2026

Copy link
Copy Markdown
Member

@netlify

netlify Bot commented Jul 23, 2026

Copy link
Copy Markdown

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit d44e767
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/6a68c1093a267600080ee1f0
😎 Deploy Preview https://deploy-preview-3713--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates OUDS Web’s button sizing API and migration tooling to reflect the latest upstream button changes (notably the deprecation of .btn-sm in favor of .btn-small), and documents the new sizing guidance.

Changes:

  • Document .btn-small sizing and update migration notes to reflect .btn-sm.btn-small and .btn-lg removal.
  • Update SCSS to support .btn-small and align internal component usage (e.g., quantity selector) with the new class name.
  • Update migrate replacement rules and snapshots to automatically migrate btn-sm to btn-small and reflect new CSS output.

Reviewed changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
site/src/content/docs/getting-started/migration-from-boosted.mdx Updates migration guidance for button size classes.
site/src/content/docs/components/buttons.mdx Adds a “Sizes” section documenting .btn-small with examples.
scss/_buttons.scss Introduces the .btn-small variant via CSS custom property overrides.
scss/forms/_quantity-selector.scss Aligns quantity selector styling with .btn-small instead of .btn-sm.
scss/_button-group.scss Minor comment update reflecting removal of .btn-sm/.btn-lg.
scss/tests/snapshot-tests/snapshots/ouds-web.css Updates CSS snapshot output for .btn-small and quantity selector selectors.
scss/tests/snapshot-tests/snapshots/ouds-web-bootstrap.css Updates Bootstrap CSS snapshot output for .btn-small and quantity selector selectors.
packages/migrate/src/replacements/boosted.mjs Changes migration behavior to replace btn-sm with btn-small (instead of warning).
packages/migrate/tests/source-boosted.html Updates migration fixture input for the btn-sm case.
packages/migrate/tests/snapshots/migrated-boosted.html Updates expected migrated output to use btn-small.
packages/migrate/src/migrate.spec.mjs Updates expected warnings list to remove the btn-sm deprecation warning.
Files not reviewed (2)
  • scss/tests/snapshot-tests/snapshots/ouds-web-bootstrap.css: Generated file
  • scss/tests/snapshot-tests/snapshots/ouds-web.css: Generated file
Comments suppressed due to low confidence (1)

site/src/content/docs/components/buttons.mdx:575

  • This sprite reference is hardcoded to /orange/docs/1.4/..., which will break on other brands and when the docs version changes. Use getVersionedDocsPath() like the other button examples in this file.
    <svg aria-hidden="true">
      <use xlink:href="/orange/docs/1.4/assets/img/ouds-web-sprite.svg#heart-empty"/>
    </svg>

Comment thread site/src/content/docs/getting-started/migration-from-boosted.mdx Outdated
Comment thread site/src/content/docs/components/buttons.mdx
Comment thread site/src/content/docs/components/buttons.mdx
@MaxLardenois

Copy link
Copy Markdown
Collaborator

Maybe do this here #3609 (comment)

@MaxLardenois MaxLardenois left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 suggestion, 1 question

Comment thread scss/_button-group.scss Outdated
Comment thread site/src/content/docs/components/buttons.mdx Outdated
Comment thread site/src/content/docs/getting-started/migration.mdx Outdated
Co-authored-by: Maxime Lardenois <maxime.lardenois@orange.com>

@MaxLardenois MaxLardenois left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve but I think it would be nice to include #3609 in here

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Jul 27, 2026

@MaxLardenois MaxLardenois left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not part of you modification but otherwise it's not clear

Comment thread site/src/content/docs/components/buttons.mdx Outdated
@boosted-bot boosted-bot moved this from Need Lead Dev Review to Dev Review In Progress in 🟣 [Orange-Boosted-Bootstrap] PRs Board Jul 28, 2026
Co-authored-by: Maxime Lardenois <maxime.lardenois@orange.com>
@boosted-bot boosted-bot moved this from Dev Review In Progress to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Need Lead Dev Review

Development

Successfully merging this pull request may close these issues.

[OUDS] Update buttons with documentation on multiline

5 participants