CDOM: mark CNAbility + CNAbilitySelection final (CT_CONSTRUCTOR_THROW)#7635
Open
Vest wants to merge 1 commit into
Open
CDOM: mark CNAbility + CNAbilitySelection final (CT_CONSTRUCTOR_THROW)#7635Vest wants to merge 1 commit into
Vest wants to merge 1 commit into
Conversation
Same shape as PR PCGen#7627, which marked 20 leaf classes final to silence SpotBugs CT_CONSTRUCTOR_THROW. These two classes escaped that PR's net. Verified via grep that no subclasses exist in code/src/{java,test,itest,slowtest}; the only matches for "extends CNAbility" / "extends CNAbilitySelection" are `<? extends ...>` generic wildcards, not class inheritance. SpotBugs XML delta confirms exactly 3 CT_CONSTRUCTOR_THROW findings cleared (CNAbility one constructor, CNAbilitySelection two constructors), 0 new findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same shape as PR #7627, which marked 20 leaf classes final to silence SpotBugs CT_CONSTRUCTOR_THROW. These two classes escaped that PR's net.
Verified via grep that no subclasses exist in
code/src/{java,test,itest,slowtest}; the only matches for "extends CNAbility" / "extends CNAbilitySelection" are<? extends ...>generic wildcards, not class inheritance.SpotBugs XML delta confirms exactly 3 CT_CONSTRUCTOR_THROW findings cleared (CNAbility one constructor, CNAbilitySelection two constructors), 0 new findings.