Auth: request-link and verify flows#46
Open
RandyJDean wants to merge 1 commit into
Open
Conversation
- AuthService.requestLink: normalize email, Bucket4j rate limits (3/email + 10/IP per 15 min) enforced silently, invalidate prior tokens, email a 15-minute single-use link via the EmailSender port (dev profile logs the link instead of sending) - AuthService.verify: atomic UPDATE..RETURNING consume, shell member creation on first login (ON CONFLICT DO NOTHING + re-select) - Generic response contract: request-link always answers the same way, so account existence and rate limiting are unobservable - InvalidMagicLinkException -> 400 failure envelope Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 9, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 9, 2026
|
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/10/26)2 reviewers were added to this PR based on Henry Chen's automation. |
arklian
reviewed
Jul 10, 2026
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.patinanetwork.patchats.email.EmailSender; |
Contributor
There was a problem hiding this comment.
We should put this dependency behind a client and have a standardized way of calling it.
Otherwise spaghetti will ensue with dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(3/email + 10/IP per 15 min) enforced silently, invalidate prior
tokens, email a 15-minute single-use link via the EmailSender port
(dev profile logs the link instead of sending)
creation on first login (ON CONFLICT DO NOTHING + re-select)
so account existence and rate limiting are unobservable
Co-Authored-By: Claude Fable 5 noreply@anthropic.com