Init design doc#53
Open
rootandroo wants to merge 1 commit into
Open
Conversation
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+33
to
+34
| WHERE c.run_at >= TIMESTAMPTZ '2026-01-01' | ||
| AND c.run_at < TIMESTAMPTZ '2027-01-01'; |
There was a problem hiding this comment.
The SQL query uses hardcoded dates '2026-01-01' and '2027-01-01' instead of parameterizing the {year} path variable. If implemented as written, the endpoint will ignore the year parameter and always return matches for 2026 only.
Fix: Replace with parameterized dates:
WHERE c.run_at >= TIMESTAMPTZ :year || '-01-01'
AND c.run_at < TIMESTAMPTZ (:year + 1) || '-01-01'
Suggested change
| WHERE c.run_at >= TIMESTAMPTZ '2026-01-01' | |
| AND c.run_at < TIMESTAMPTZ '2027-01-01'; | |
| WHERE c.run_at >= TIMESTAMPTZ :year || '-01-01' | |
| AND c.run_at < TIMESTAMPTZ (:year + 1) || '-01-01'; | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/11/26)2 reviewers were added to this PR based on Henry Chen's automation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.