Allow partial observations and remove dependence on OpenCV Mat types#28
Open
thatcomputerguy0101 wants to merge 1 commit into
Open
Allow partial observations and remove dependence on OpenCV Mat types#28thatcomputerguy0101 wants to merge 1 commit into
thatcomputerguy0101 wants to merge 1 commit into
Conversation
thatcomputerguy0101
force-pushed
the
partial-observations
branch
from
62a94e4 to
8b94e58
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of my refactor to improve the handling of OpenCV's Mats in PhotonVision/photonvision#2511, this pushes the responsibility for conversion to arrays onto the caller so that this library doesn't have to deal with Mats. Also, this takes on the responsibility of skipping unobserved points, allowing the observation mats to be immutable. By accepting an iterator here, the amount of data loaded into memory at once can be reduced for highly repetitive data like levels.