Exempt "either"-sign probes from the preflight sign-contradiction check#440
Merged
Conversation
The static smoke-probe audit mapped expected_sign to a boolean (expected_positive = sign == "positive"), so a probe declaring expected_sign="either" (#437: net direction is a frame property, not a coverage property) was treated as expecting NEGATIVE and any positive net was flagged "contradicts the probe's expected_sign='either'" - a self-contradictory advisory the Build M launch checklist hit on the farm probe after #437 moved it to "either". A probe declaring "either" asserts no direction, so the sign-contradiction check now skips it; the support/thin-selection and magnitude teeth are unchanged. Regression test mirrors the contradiction fixture with expected_sign="either" and asserts PASS with verdict "supported". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #437 moved the farm probe to
expected_sign: "either", the Build M launch preflight still flags it:A positive net cannot contradict "either" — the static checker mapped
expected_signto a boolean (expected_positive = sign == "positive"), so "either" was treated as "negative". The in-run smoke gate handles "either" correctly (#437); only the static preview was wrong.What
check_smoke_probe_supportskips the sign-contradiction check for probes declaring"either"(they assert no direction). Support, thin-selection, and the run-time magnitude teeth are unchanged.test__smoke_probe_support__either_sign_probe__no_sign_flag: same materially-signed net-positive fixture as the contradiction test, probe declares "either" → PASS, verdictsupported. Fails against the pre-fix behavior.With this, the Build M preflight's farm advisory clears; the remaining export-mass parity advisories are the adjudicated-safe base-weight signals (targeted columns lifted by the solve — attempt 11 passed the parity gate at export with identical base drifts).
🤖 Generated with Claude Code