Conversation
sivadurga-d
approved these changes
Jul 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new provider entry for lightning-ai by introducing pricing data and general capability/parameter configuration so the models can be surfaced consistently alongside existing providers.
Changes:
- Added
pricing/lightning-ai.jsonwith default pricing calculation/currency and per-model pay-as-you-go rates. - Added
general/lightning-ai.jsonwith provider defaults (params/message roles) and per-model capability flags (e.g., image support).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pricing/lightning-ai.json | Introduces Lightning AI pricing configuration (default calculation + model rate overrides). |
| general/lightning-ai.json | Introduces Lightning AI model capability/parameter configuration (defaults + per-model type/supported flags). |
Comments suppressed due to low confidence (4)
general/lightning-ai.json:120
- For
openai/o3-mini, the entry currently has no model-specificmax_tokenslimit and does not advertise tool support. Other provider-aggregator configs in this repo setmax_tokensup to 100000 and mark tool support for this model; without this, clients may be constrained incorrectly or miss supported features.
"openai/o3-mini": {
"type": { "primary": "chat", "supported": [] }
},
general/lightning-ai.json:123
- For
openai/gpt-4o, the config currently only listsimagesupport and inherits the defaultmax_tokenslimit. In other configs in this repo this model supports tools and has a smaller max_tokens cap; consider explicitly setting these to avoid clients sending out-of-range values.
"openai/gpt-4o": {
"type": { "primary": "chat", "supported": ["image"] }
},
general/lightning-ai.json:129
- For
openai/gpt-4-turbo-preview, the config currently has an emptysupportedlist and inherits the defaultmax_tokenslimit. This model typically supports tool calling and a lower max_tokens cap; without overrides, clients may attempt unsupported parameter values/features.
"openai/gpt-4-turbo-preview": {
"type": { "primary": "chat", "supported": [] }
},
general/lightning-ai.json:132
- For
openai/gpt-3.5-turbo, the entry currently omits tool support and inherits the defaultmax_tokensmaxValue (32768). Other configs in this repo constrain this model to a 4096 max_tokens limit and mark tool support; consider aligning to prevent clients sending unsupported requests.
"openai/gpt-3.5-turbo": {
"type": { "primary": "chat", "supported": [] }
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+112
to
+114
| "openai/o3": { | ||
| "type": { "primary": "chat", "supported": ["image"] } | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.