Skip to content

fix(agent): pin codex approvals_reviewer to host #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rnegron wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −0
Open

fix(agent): pin codex approvals_reviewer to host #3435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac7a0bf
fix(agent): pin codex approvals_reviewer to host
rnegron Jul 14, 2026
3868e63
fix(agent): guard codex reviewer pin from override
rnegron Jul 14, 2026
6411648
refactor(agent): simplify codex reviewer default
rnegron Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/agent/src/adapters/codex-app-server/spawn.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ describe("buildAppServerArgs", () => {
});

expect(args[0]).toBe("app-server");
// Pin codex's guardian reviewer to the host default so it never calls the
// gateway-blocked `codex-auto-review` model.
expect(args).toContain('approvals_reviewer="user"');
expect(args).toContain('model_provider="posthog"');
expect(args).toContain(
'model_providers.posthog.base_url="https://gateway.example/v1"',
Expand Down
7 changes: 7 additions & 0 deletions packages/agent/src/adapters/codex-app-server/spawn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,13 @@ export function buildAppServerArgs(
: `sandbox_mode="danger-full-access"`,
);

// The host owns approvals (surfaced via approvals.ts → requestPermission). Codex's
// guardian reviewer is on by default and routes approvals to its dedicated
// `codex-auto-review` model, which our gateway's posthog_code allowlist doesn't
// serve — so every review 403s. Default codex's own `user` reviewer; a caller can
// still override it via configOverrides, which the trailing loop appends last.
args.push("-c", `approvals_reviewer="user"`);

// Disable the user's ambient ~/.codex MCP servers so the adapter only exposes
// MCP servers PostHog injects per-thread; otherwise codex fails connecting to them.
for (const name of new CodexSettingsManager(
Expand Down
Loading