refactor(shared): move the SKILL.md serializer into @posthog/shared#3445
Merged
Conversation
serializeSkillMarkdown lived in workspace-server; move it to @posthog/shared and have workspace-server re-export it. SKILL.md is a serialization contract the cloud sandbox consumes, so any client that emits skills (the workspace-server bundler today, a browser bundler later) must produce byte-identical output — sharing one implementation keeps them from drifting. No behavior change: desktop's bundler resolves the same function through the re-export. Generated-By: PostHog Code Task-Id: 77d13a30-444d-4045-9d80-5e2a9f2e68ae
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "refactor(shared): move the SKILL.md seri..." | Re-trigger Greptile |
This was referenced Jul 14, 2026
jonathanlab
approved these changes
Jul 15, 2026
Member
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
serializeSkillMarkdownfrom@posthog/workspace-serverinto@posthog/shared; workspace-server now re-exports it.Why
SKILL.mdis a serialization contract the cloud sandbox consumes. Any client that emits skills must produce byte-identical output. Today that's the workspace-server bundler; a browser skill bundler is coming. Sharing one implementation keeps them from drifting.No behavior change — desktop's bundler resolves the same function through the re-export, and the existing
write-skill-frontmattertests are untouched and pass.This is one of a few small enabling changes peeled out of the
apps/webbrowser-host work (previously #3353).Testing
@posthog/shared+@posthog/workspace-servertypecheck pass.Created with PostHog Code