fix(command-center): question prompt no longer blocks thread scroll#3448
Open
digvijay208 wants to merge 1 commit into
Open
fix(command-center): question prompt no longer blocks thread scroll#3448digvijay208 wants to merge 1 commit into
digvijay208 wants to merge 1 commit into
Conversation
When a question/permission prompt appeared in a Command Center cell, the ComposerSlot wrapper had shrink-0, preventing the flex parent from keeping the ThreadView visible. Combined with ActionSelector's max-h-[80vh] (80% of the viewport, not the cell), the question card could consume the entire compact cell, making it impossible to scroll up to see past messages. Fix: in compact mode, drop shrink-0 and cap the slot at max-h-[50%] of the parent. The question prompt scrolls internally via overflow-y-auto if it's taller than half the cell, while the ThreadView above remains accessible. Non-compact behavior is unchanged. Fixes PostHog#2510
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
An error occurred while submitting your PR to the queue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2510.
When a question/permission prompt appeared in a Command Center cell, the
ComposerSlotwrapper hadshrink-0, preventing the flex layout from yielding space to theThreadViewabove. Combined withActionSelector'smax-h-[80vh](80% of the viewport, not the cell), the question card could consume the entire visible area in a compact command-center cell, making it impossible to scroll up to read past messages.Root cause
Changes
packages/ui/src/features/sessions/components/SessionView.tsxIn
ComposerSlot, dropshrink-0and addmax-h-[50%]in compact mode so the question card never consumes more than half the cell height. The thread above remains scrollable. Non-compact (full task view) behavior is unchanged.Testing
questiontool call)