fix: handle compaction boundaries without metadata#3452
Open
MattPua wants to merge 1 commit into
Open
Conversation
Generated-By: PostHog Code Task-Id: 7f369b7a-64cf-4bac-8653-4061a42237c6
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found 2 issues in 1 file · 2 warnings. 2 warnings
Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix: handle compaction boundaries withou..." | Re-trigger Greptile |
Contributor
|
Reviews (2): Last reviewed commit: "fix: handle compaction boundaries withou..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Codex emits
_posthog/compact_boundarywithout Claude's optionaltrigger,preTokens, andcontextSizemetadata. The UI treated those fields as required, so Codex compactions rendered asConversation compacted · undefined · ~NaNK tokens.With Codex

Changes
How did you test this?
pnpm --dir packages/ui exec vitest run src/features/sessions/components/session-update/CompactBoundaryView.test.ts src/features/sessions/components/buildConversationItems.test.tspnpm --filter @posthog/ui typecheckpnpm typecheckAutomatic notifications
Created with PostHog Code