fix(sidebar): Move Alpha and Beta badges next to labels#3456
Merged
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "move alpha and beta badges next to label..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
charlesvien
added
the
Stamphog
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Low-risk presentational fix that correctly moves Alpha/Beta badges to a dedicated prop outside the truncating label span. The bot's truncation concerns are genuinely resolved by the implementation — the badge is a sibling with shrink-0, not nested inside the clipping span.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Alpha and Beta badges on the Home and Inbox nav items were pinned to the right edge of the sidebar while Contexts renders its badge next to the label, so the nav looked out of sync.
Changes
Added a
badgeslot toSidebarItemthat sits next to the label without truncating with it, and moved the Home and Inbox badges into it. Shortcut hints stay right-aligned.Home is behind the home-tab flag and not visible here; it uses the same slot as Inbox.
How did you test this?
pnpm --filter @posthog/ui typecheck, Biome on the changed files and verified in the running dev app (screenshot above).Automatic notifications