chore(dev): Group dev processes into phrocs categories#3457
Merged
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
Reviews (1): Last reviewed commit: "add phrocs layer groups to mprocs config" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The phrocs sidebar shows all dev processes as one flat list, ordered by numeric name prefixes (
1-code,2-agent). The posthog repo groups its processes into categories, which reads much better as the process count grows.Changes
Adds
groups.layerto each process plusdefault_groupandgroup_order, so the phrocs sidebar groups processes into Application, Packages and Tools. Drops the numeric name prefixes since grouping replaces them for ordering, which also makescode'sdepends_onentries match real process names. Stock mprocs (pnpm dev:mprocs) ignores the new keys, so the fallback keeps working.How did you test this?
Ran both
phrocs --config mprocs.yamlandmprocs --config mprocs.yamlheadless: both parse the new config cleanly and fail only on the missing TTY.Automatic notifications