fix: show Codex subagent activity without streaming child output#3465
Merged
richardsolomou merged 7 commits intoJul 15, 2026
Merged
Conversation
Keep child-thread output, usage, compaction, and completion notifications from mutating the parent ACP session. Generated-By: PostHog Code Task-Id: 971044c5-e622-4f07-b1b5-dca9b06d040c
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Keep compact collaboration rows and accurate status while child-thread output and lifecycle notifications remain isolated from the parent session. Generated-By: PostHog Code Task-Id: 971044c5-e622-4f07-b1b5-dca9b06d040c
Exercise the cloud task completion signal and document why child notifications must be filtered before ACP log persistence. Generated-By: PostHog Code Task-Id: 971044c5-e622-4f07-b1b5-dca9b06d040c
Read canonical tool metadata in the grouped conversation header so Codex spawn batches no longer fall back to the generic Other label. Generated-By: PostHog Code Task-Id: 971044c5-e622-4f07-b1b5-dca9b06d040c
Contributor
|
Reviews (1): Last reviewed commit: "Label Codex collaboration groups as suba..." | Re-trigger Greptile |
Preserve terminal tool-call status, discard child output before buffering, and reserve the subagent UI for actual spawn operations. Add regressions for structured output, command buffering, active labels, and orchestration rendering. Generated-By: PostHog Code Task-Id: 971044c5-e622-4f07-b1b5-dca9b06d040c
tatoalo
approved these changes
Jul 15, 2026
Remove the duplicate bippy package key introduced by the Storybook lockfile update so frozen installs can parse the lockfile. Generated-By: PostHog Code Task-Id: 971044c5-e622-4f07-b1b5-dca9b06d040c
|
Could not verify team-posthog-code membership (GitHub API error). Auto-release is limited to Team PostHog Code members, so this will ship with the next scheduled release instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Codex app-server multiplexes parent and subagent notifications over one connection. Treating child-thread events as parent state interleaves delegated output into the conversation, pollutes parent usage and compaction state, and can mark the parent turn complete while work is still running. Simply dropping every subagent-related event would also hide useful delegation status.
Why: The conversation should behave like Claude: show compact parent-level delegation activity, let the parent model consume final results, and keep child transcripts out of the user-visible thread.
Changes
threadIdwhile preserving child MCP tracking for approvals.The pinned Codex implementation returns final subagent messages to the parent through
wait_agent, so genuine parent-context growth from those results remains unchanged. Child notification streams no longer affect parent context indicators or lifecycle state.Cloud tasks run the published
@posthog/agentfrom the sandbox image rather than the package checked out in the task workspace. Cloud validation therefore requires this agent change to merge, publish, and trigger the sandbox image rebuild. Existing logs produced by older agents cannot be repaired safely during replay because normalized ACP updates no longer identify the originating Codex thread.Screenshots are not included because the behavior depends on live multi-agent event routing and is covered by adapter, mapping, and conversation-grouping tests.
How did you test this?
pnpm --filter @posthog/agent typecheck.pnpm --filter @posthog/ui typecheck.git diff --check.The full agent suite was also attempted, but unrelated tests that create temporary Git commits cannot run in this environment because unsigned
git commitis intentionally blocked.Automatic notifications
Created with PostHog Code