fix(agent): support /goal in Codex cloud runs#3467
Merged
Conversation
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Translate Codex /goal commands to native app-server goal RPCs and advertise the command alongside skills. Add regression coverage for reading, setting, clearing, pausing, and resuming goals without starting a model turn. Generated-By: PostHog Code Task-Id: f8939190-58a1-493b-904c-457c7859b3d6
9e8e486 to
93c4fdb
Compare
Generated-By: PostHog Code Task-Id: f8939190-58a1-493b-904c-457c7859b3d6
Generated-By: PostHog Code Task-Id: f8939190-58a1-493b-904c-457c7859b3d6
Contributor
|
Reviews (1): Last reviewed commit: "fix(agent): preserve Codex goals across ..." | Re-trigger Greptile |
Generated-By: PostHog Code Task-Id: f8939190-58a1-493b-904c-457c7859b3d6
Generated-By: PostHog Code Task-Id: f8939190-58a1-493b-904c-457c7859b3d6
There was a problem hiding this comment.
Both concrete bugs flagged by bot reviews on older commits are fixed in the current diff: the interrupt-failure race preserves the cancellation flag until the RPC succeeds, and the goal-scan loop uses continue on malformed entries instead of an early return. The stamphog review was on an older commit; all greptile inline comments are resolved with matching fixes visible in the diff. No showstoppers in this additive goal-command feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Codex cloud runs pass
/goalthrough as ordinary model input because they bypass Codex's interactive TUI command dispatcher.Why: Cloud tasks should support the same long-running goal controls regardless of whether they use the Claude or Codex runtime adapter.
Changes
/goalcommands to the native app-server goal RPCs/goalalongside available Codex skills