trunk-merge/pr-3445/6225af46-1387-4d09-aa3e-b42fd1065ef4#3477
Closed
trunk-io[bot] wants to merge 4 commits into
Closed
trunk-merge/pr-3445/6225af46-1387-4d09-aa3e-b42fd1065ef4#3477trunk-io[bot] wants to merge 4 commits into
trunk-io[bot] wants to merge 4 commits into
Conversation
serializeSkillMarkdown lived in workspace-server; move it to @posthog/shared and have workspace-server re-export it. SKILL.md is a serialization contract the cloud sandbox consumes, so any client that emits skills (the workspace-server bundler today, a browser bundler later) must produce byte-identical output — sharing one implementation keeps them from drifting. No behavior change: desktop's bundler resolves the same function through the re-export. Generated-By: PostHog Code Task-Id: 77d13a30-444d-4045-9d80-5e2a9f2e68ae
Introduce a coarse HostCapabilities primitive ({ localWorkspaces }) in
@posthog/platform, read via useHostCapabilities (defaults to
localWorkspaces:true, so desktop is unchanged). Use it to gate local-only
UI surfaces (folder picker, terminal, worktree/cloud-mode toggles,
back/forward chrome, local settings sections, onboarding repo step) so a
future cloud-only host renders correctly — every gate is a no-op on
desktop.
Also add a DI guardrail: assertHostCapabilities + a REQUIRED_HOST_CAPABILITIES
registry of tokens shared UI resolves via service location. Each
composition root asserts them at boot, so a host that forgets a binding
fails loudly at startup instead of at the first navigation that needs it.
Desktop binds HOST_CAPABILITIES and asserts the registry on renderer boot.
Enabling change for the browser web host, peeled out of #3353; no desktop
behavior change.
Generated-By: PostHog Code
Task-Id: 77d13a30-444d-4045-9d80-5e2a9f2e68ae
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
trunk-io
Bot
deleted the
trunk-merge/pr-3445/6225af46-1387-4d09-aa3e-b42fd1065ef4
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 53ae2df78ace4dcfadfb9c7dbdcc0995817d9e0f.
See more details about each PR in the batch here:
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing a batch with the changes from pull requests 3445 and 3446 - batching documentation.